Add roo cloud settings #4117
Merged
Add roo cloud settings #4117
+205
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First setting controls logging task messages.
mrubens
reviewed
May 29, 2025
Co-authored-by: Matt Rubens <[email protected]>
mrubens
approved these changes
May 29, 2025
cte
approved these changes
May 29, 2025
Collaborator
cte
left a comment
cte
left a comment
There was a problem hiding this comment.
I think this is okay for now, but I think it might make more sense to allow the org to explicitly select which telemetry events to record (or not), and we can represent this as a TelemetryEventSubscription object and use the logic from the base class:
protected isEventCapturable(eventName: TelemetryEventName): boolean {
return this.subscription.type === "include"
? this.subscription.events.includes(eventName)
: !this.subscription.events.includes(eventName)
}
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First setting controls logging task messages.
As written this shouldn't be merged until the server side is ready, or no
TASK_MESSAGEwill ever be logged.This felt like the simplest way to do it, but it does not touch
Taskto make things really explicit. We could add something likeCloudService.instance.canCaptureMessages()if we wanted to go that route.Important
Add
recordTaskMessagessetting to controlTASK_MESSAGElogging inTelemetryClient.recordTaskMessagessetting incloud.tsto control logging ofTASK_MESSAGEevents.isEventCapturable()inTelemetryClient.tsto checkrecordTaskMessagessetting forTASK_MESSAGEevents.TASK_MESSAGEevents are only captured ifrecordTaskMessagesis true.TelemetryClient.test.tsto verifyTASK_MESSAGEcapture behavior based onrecordTaskMessagessetting.CloudService.tsto passSettingsServicetoTelemetryClientconstructor.This description was created by
for a94d761. You can customize this summary. It will automatically update as commits are pushed.